gemmellr commented on code in PR #4458: URL: https://github.com/apache/activemq-artemis/pull/4458#discussion_r1182446328
########## artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/jaas/HttpServerAuthenticator.java: ########## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.activemq.artemis.spi.core.security.jaas; + +import javax.security.auth.Subject; +import javax.security.auth.callback.Callback; +import javax.security.auth.callback.NameCallback; +import javax.security.auth.callback.PasswordCallback; +import javax.security.auth.callback.UnsupportedCallbackException; +import javax.security.auth.login.LoginContext; + +import java.nio.charset.StandardCharsets; +import java.security.Principal; +import java.security.cert.Certificate; +import java.security.cert.X509Certificate; +import java.util.Arrays; +import java.util.Base64; +import java.util.StringTokenizer; + +import com.sun.net.httpserver.Authenticator; +import com.sun.net.httpserver.HttpExchange; +import com.sun.net.httpserver.HttpPrincipal; +import com.sun.net.httpserver.HttpsExchange; + +/** + * delegate to our JAAS login modules by adapting our handlers to httpserver.httpExchange + */ +public class HttpServerAuthenticator extends Authenticator { + + static final String REALM_PROPERTY_NAME = "httpServerAuthenticator.realm"; + static final String REQUEST_SUBJECT_ATTRIBUTE_PROPERTY_NAME = "httpServerAuthenticator.requestSubjectAttribute"; + static String DEFAULT_SUBJECT_ATTRIBUTE = "org.apache.activemq.artemis.jaasSubject"; + static final String DEFAULT_REALM = "http_server_authenticator"; + static final String AUTHORIZATION_HEADER_NAME = "Authorization"; + + final String realm = System.getProperty(REALM_PROPERTY_NAME, DEFAULT_REALM); + final String subjectRequestAttribute = System.getProperty(REQUEST_SUBJECT_ATTRIBUTE_PROPERTY_NAME, DEFAULT_SUBJECT_ATTRIBUTE); + + @Override + public Result authenticate(HttpExchange httpExchange) { + + try { + LoginContext loginContext = new LoginContext(realm, callbacks -> { + for (Callback callback : callbacks) { + if (callback instanceof PasswordCallback) { + PasswordCallback passwordCallback = (PasswordCallback) callback; + + StringTokenizer stringTokenizer = new StringTokenizer(extractAuthHeader(httpExchange)); + String method = stringTokenizer.nextToken(); + if ("Basic".equalsIgnoreCase(method)) { + byte[] authHeaderBytes = Base64.getDecoder().decode(stringTokenizer.nextToken()); + + // :pass + byte[] password = Arrays.copyOfRange(authHeaderBytes, Arrays.binarySearch(authHeaderBytes, (byte) ':') + 1, authHeaderBytes.length); + passwordCallback.setPassword(new String(password, StandardCharsets.UTF_8).toCharArray()); + } else if ("Bearer".equalsIgnoreCase(method)) { + passwordCallback.setPassword(stringTokenizer.nextToken().toCharArray()); + } + } else if (callback instanceof NameCallback) { + NameCallback nameCallback = (NameCallback) callback; + + StringTokenizer stringTokenizer = new StringTokenizer(extractAuthHeader(httpExchange)); + String method = stringTokenizer.nextToken(); + if ("Basic".equalsIgnoreCase(method)) { + byte[] authHeaderBytes = Base64.getDecoder().decode(stringTokenizer.nextToken()); + + // user: + byte[] user = Arrays.copyOfRange(authHeaderBytes, 0, Arrays.binarySearch(authHeaderBytes, (byte) ':')); + nameCallback.setName(new String(user)); Review Comment: same charset issue as earlier comment ########## artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/jaas/HttpServerAuthenticator.java: ########## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> Review Comment: Content is still the old javadoc/mis-formatted version. Copy over the comment version from other files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
