jbertram commented on code in PR #4461:
URL: https://github.com/apache/activemq-artemis/pull/4461#discussion_r1186286615
##########
artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/ActiveMQJAASSecurityManager.java:
##########
@@ -141,8 +141,9 @@ private Subject getAuthenticatedSubject(final String user,
try {
lc.login();
} catch (LoginException e) {
- Throwable rootCause = ExceptionUtil.getRootCause(e);
+ Throwable rootCause = ExceptionUtils.getRootCause(e);
if (rootCause instanceof NoCacheLoginException) {
+ logger.debug("Handling LoginException with
NoCacheLoginException root cause", e);
Review Comment:
I considered that approach originally, but I would have to add a new
interface (e.g. `ActiveMQSecurityManager6`) where `authenticate` could throw a
checked exception. The security manager is pluggable and some users implement
their own so we can't just change the interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
