jbertram commented on code in PR #4473:
URL: https://github.com/apache/activemq-artemis/pull/4473#discussion_r1194392403
##########
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/critical/CriticalAnalyzerImpl.java:
##########
@@ -48,11 +51,28 @@ public CriticalAnalyzerImpl() {
* issues and won't be able to shutdown the server or halt the VM
*/
this.scheduledComponent = new ActiveMQScheduledComponent(null, null,
checkTimeNanoSeconds, TimeUnit.NANOSECONDS, false) {
+
@Override
public void run() {
logger.trace("Checking critical analyzer");
check();
}
+
+ @Override
+ protected ActiveMQThreadFactory getThreadFactory() {
+ return new ActiveMQThreadFactory("CriticalAnalyzer",
"Critical-Analyzer-", true, getThisClassLoader());
Review Comment:
I was mixed up on how daemon threads related to the JVM exiting. Sorry for
the confusion. This looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
