cshannon commented on code in PR #1005:
URL: https://github.com/apache/activemq/pull/1005#discussion_r1196517948


##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/Queue.java:
##########
@@ -957,6 +957,11 @@ private void checkUsage(ConnectionContext 
context,ProducerBrokerExchange produce
     }
 
     private void expireMessages() {
+        if(isDispatchPaused()) {

Review Comment:
   QueueDispatchSelector is final which is fine, specifically the paused flag 
inside that class isn't volatile because it's usually accessed under the 
consumer write lock everywhere



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to