clebertsuconic commented on code in PR #4482:
URL: https://github.com/apache/activemq-artemis/pull/4482#discussion_r1197926438
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java:
##########
@@ -737,12 +739,13 @@ public ClientSessionFactory createSessionFactory() throws
ActiveMQException {
// how the sendSubscription happens.
// in case this ever changes.
if (topology != null && !factory.waitForTopology(config.callTimeout,
TimeUnit.MILLISECONDS)) {
+ synchronized (factories) {
+ factories.remove(factory);
Review Comment:
I think you should create a private method removeFactory(factory)
and that method should do the synchronized(factories)
just for readability?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
