gemmellr commented on code in PR #4485: URL: https://github.com/apache/activemq-artemis/pull/4485#discussion_r1202678262
########## tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/federation/FederatedQueueConsumerTest.java: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.activemq.artemis.tests.integration.federation; + +import org.apache.activemq.artemis.core.config.FederationConfiguration; +import org.apache.activemq.artemis.core.server.ActiveMQServer; +import org.apache.activemq.artemis.core.server.federation.FederatedQueueConsumerImpl; +import org.apache.activemq.artemis.core.server.federation.Federation; +import org.apache.activemq.artemis.tests.util.ActiveMQTestBase; +import org.apache.activemq.artemis.tests.util.RandomUtil; +import org.apache.activemq.artemis.utils.Wait; +import org.junit.Test; + +public class FederatedQueueConsumerTest extends ActiveMQTestBase { + + @Test + public void testClose() throws Exception { + ActiveMQServer server = createServer(false, createDefaultInVMConfig()); + server.start(); + Federation federation = new Federation(server, new FederationConfiguration().setName(RandomUtil.randomString())); + federation.start(); + FederatedQueueConsumerImpl consumer = new FederatedQueueConsumerImpl(federation, server, null, null, null, null); + consumer.start(); + Wait.assertTrue(() -> consumer.getCurrentConnectTask() != null, 2000, 20); + consumer.close(); + Wait.assertTrue(() -> consumer.getCurrentConnectTask().isDone() || consumer.getCurrentConnectTask().isCancelled(), 2000, 50); Review Comment: To cover the potential re-scheduling race, may be worth adding a check that calling consumer.getCurrentConnectTask() again returns the same future. So, its done and you get the same one, or its cancelled and you get the same one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
