rvais commented on PR #4403:
URL: 
https://github.com/apache/activemq-artemis/pull/4403#issuecomment-1562632251

   I like the approach, but it somewhat duplicates already existing locking 
mechanism. There is for example 
https://github.com/apache/activemq-artemis/blob/main/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/jdbc/JdbcSharedStateManager.java.
 It would be good to somewhat unify the approach. The time I have spent on 
reading the code and my understanding of implemented locking mechanism is 
limited so it would be worth to spend some more time on this. I will check this 
out later again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to