gemmellr commented on code in PR #4410: URL: https://github.com/apache/activemq-artemis/pull/4410#discussion_r1205355650
########## docs/user-manual/en/configuration-index.md: ########## @@ -481,3 +484,285 @@ Name | Description | Default [password](amqp-broker-connections.md#amqp-server-connections) | Broker authentication password (optional) | n/a [reconnect-attempts](amqp-broker-connections.md#amqp-server-connections) | How many attempts should be made to reconnect after failure. | -1 (infinite) [auto-start](amqp-broker-connections.md#amqp-server-connections) | Broker connection starts automatically with broker | true + + +## Broker Properties Reference Review Comment: The documentation I suggested referencing outlines the naming to an extent already, https://github.com/apache/activemq-artemis/blob/2.28.0/docs/user-manual/en/configuration-index.md#broker-properties I think even more so now that the behaviour arounds defaults need to be clearer. It came up in another context since that earlier comment, in #4297 where I eventually realised (and argued, it isnt clear to a user of it) that the 'properties image' will actually behave quite differently out-of-the-box than the standalone broker and artemis-docker based images that use the 'standard supplied XML' which already overrides various code defaults. This PRs existing docs on 'Default' would actually currently best suit/describe what happens in a 'properties-only image' case, while potentially misleading in the 'standard supplied XML image' currently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
