rvais commented on code in PR #4452:
URL: https://github.com/apache/activemq-artemis/pull/4452#discussion_r1209448623
##########
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java:
##########
@@ -848,7 +848,7 @@ private ActiveMQMessageConsumer createConsumer(final
ActiveMQDestination dest,
if (!response.isExists() ||
!response.getQueueNames().contains(AutoCreateUtil.getCoreQueueName(session,
dest.getSimpleAddress()))) {
if (response.isAutoCreateQueues()) {
try {
- createQueue(dest, RoutingType.MULTICAST,
dest.getSimpleAddress(), null, true, true, response);
+ createQueue(dest, RoutingType.MULTICAST,
dest.getSimpleAddress(), coreFilterString, true, true, response);
Review Comment:
This usecase could also use a test. Now that I think about it. Wouldn't it
make sense to pair the filter with session, rather than the queue? In such
case, the messages that don't fit the with the filter could still be consumed
by a different client later on. Especially in case the queue haven't been
created with any filter previously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
