gemmellr commented on code in PR #4452:
URL: https://github.com/apache/activemq-artemis/pull/4452#discussion_r1209989962
##########
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java:
##########
@@ -848,7 +848,7 @@ private ActiveMQMessageConsumer createConsumer(final
ActiveMQDestination dest,
if (!response.isExists() ||
!response.getQueueNames().contains(AutoCreateUtil.getCoreQueueName(session,
dest.getSimpleAddress()))) {
if (response.isAutoCreateQueues()) {
try {
- createQueue(dest, RoutingType.MULTICAST,
dest.getSimpleAddress(), null, true, true, response);
+ createQueue(dest, RoutingType.MULTICAST,
dest.getSimpleAddress(), coreFilterString, true, true, response);
Review Comment:
The main reason to do it on the queue is specifically to avoid messages that
'werent asked for' originally for a topic-subscription-like-FQQN-queue (note
this bit is specific to multicast/topic) from accumulating on the queue where
they wont then be consumed (as e.g is happening for an AMQP case before this
PR).
For real-topic-subscriptions comparison, JMS doesnt allow selectors to
differ on a single sub (while sharing) and changing it later constitutes a new
subscription beginning from that point without previous messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
