gemmellr commented on code in PR #4489:
URL: https://github.com/apache/activemq-artemis/pull/4489#discussion_r1224052630
##########
tests/activemq5-unit-tests/src/test/java/org/apache/activemq/command/MessageCompressionTest.java:
##########
@@ -216,13 +216,37 @@ public void testObjectMessageCompression() throws
Exception {
assertTrue("expected: compressed Size '" + compressedSize + "' <
unCompressedSize '" + unCompressedSize + "'", compressedSize <
unCompressedSize);
}
+ public void testLargeObjectMessageCompression() throws Exception {
Review Comment:
Although it certainly matches the surroundings, I dont think this test
should be added here. These classes are somewhat extra ones originally ported
across from the 5.x test suite, they dont typically have new tests added into
them.
The test should instead go in the integration-tests module, perhaps fitting
in the existing
org.apache.activemq.artemis.tests.integration.openwire.interop.CompressedInteropTest
class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
