gemmellr commented on code in PR #4512:
URL: https://github.com/apache/activemq-artemis/pull/4512#discussion_r1237023946
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java:
##########
@@ -1573,13 +1573,13 @@ void slowConsumerDetected(String sessionID,
@LogMessage(id = 224122, value = "Address {} number of messages is under
page limit again, and it should be allowed to page again.", level =
LogMessage.Level.INFO)
void pageFree(SimpleString address);
- @LogMessage(id = 224123, value = "Address {} has more pages than allowed.
System currently has {} pages, while the estimated max number of pages is {},
based on the limitPageBytes ({}) / page-size ({})", level =
LogMessage.Level.WARN)
- void pageFullMaxBytes(SimpleString address, long pages, long maxPages, long
limitBytes, long bytes);
+ @LogMessage(id = 224123, value = "Address {} has more pages than allowed.
System currently has {} pages, while the estimated max number of pages is {}
based on the page-limit-bytes ({}) / page-size ({})", level =
LogMessage.Level.WARN)
+ void pageFullMaxBytes(SimpleString address, long pages, Long maxPages, Long
limitBytes, int bytes);
Review Comment:
If the value can be null then having the logger method allow for that seems
reasonable...however...
If the limit value was null, why was it even logging that a non-existent
limit was exceeded? Does this only happen when the value is removed/changed
while already running, or something? Or is this pointing to an actual
behavioural problem somewhere leading to a mis-logging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
