gemmellr commented on code in PR #4526:
URL: https://github.com/apache/activemq-artemis/pull/4526#discussion_r1245342785
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/OperationContextImpl.java:
##########
@@ -415,4 +449,27 @@ public String toString() {
executorsPendingField +
"]";
}
+
+ @Override
+ public void clear() {
+ stored = 0;
+ storeLineUpField = 0;
+ minimalReplicated = 0;
+ replicated = 0;
+ replicationLineUpField = 0;
+ paged = 0;
+ minimalPage = 0;
+ pageLineUpField = 0;
+ errorCode = -1;
+ errorMessage = null;
+ executorsPendingField = 0;
+
+ if (tasks != null) {
+ tasks.clear();
+ }
+
+ if (storeOnlyTasks != null) {
+ storeOnlyTasks.clear();
+ }
Review Comment:
So I guess the question is really just, what are the potential consequences
of corrupting the list and is it important?
Closing 'stuck' sessions is what the method is being added for, but its not
necessarily when it will actually be called. I expect some folks will use the
'force' just because it exists at all, to avoid having to think whether they
actually need it or not. E.g the same way folks use rm -rf a lot of the time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
