gemmellr commented on code in PR #4530:
URL: https://github.com/apache/activemq-artemis/pull/4530#discussion_r1253370626
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/server/impl/RemotingServiceImpl.java:
##########
@@ -582,7 +582,7 @@ public void connectionCreated(final ActiveMQComponent
component,
public void addConnectionEntry(Connection connection, ConnectionEntry
entry) {
connections.put(connection.getID(), entry);
if (AuditLogger.isResourceLoggingEnabled()) {
-
AuditLogger.createdConnection(connection.getProtocolConnection().getProtocolName(),
connection.getID(), connection.getRemoteAddress());
+ AuditLogger.createdConnection(connection.getProtocolConnection() ==
null ? null : connection.getProtocolConnection().getProtocolName(),
connection.getID(), connection.getRemoteAddress());
Review Comment:
Having the local-address in the actual audit log also seems like it would be
[more] useful here, as in the handshake failure case. Probably a separate
change though.
##########
tests/smoke-tests/src/main/resources/servers/audit-logging2/log4j2.properties:
##########
@@ -30,6 +30,9 @@ logger.artemis_journal.level=INFO
logger.artemis_utils.name=org.apache.activemq.artemis.utils
logger.artemis_utils.level=INFO
+logger.StompConnection.name=org.apache.activemq.artemis.core.protocol.stomp.StompConnection
+logger.StompConnection.level=TRACE
+
Review Comment:
Is this still needed if the new tests moved to AuditLoggerResourceTest?
(looks to use different server config)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
