amarkevich commented on code in PR #4540:
URL: https://github.com/apache/activemq-artemis/pull/4540#discussion_r1255868866
##########
pom.xml:
##########
@@ -1097,6 +1094,13 @@
<arg>-XDcompilePolicy=simple</arg>
<arg>-Xplugin:ErrorProne
-Xep:ThreadLocalUsage:ERROR -Xep:MissingOverride:ERROR
-Xep:NonAtomicVolatileUpdate:ERROR -Xep:SynchronizeOnNonFinalField:ERROR
-Xep:StaticQualifiedUsingExpression:ERROR -Xep:WaitNotInLoop:ERROR
-Xep:BanJNDI:OFF -XepExcludedPaths:.*/generated-sources/.*</arg>
</compilerArgs>
+ <annotationProcessorPaths>
+ <path>
+ <groupId>com.google.errorprone</groupId>
+ <artifactId>error_prone_core</artifactId>
+ <version>${errorprone.version}</version>
+ </path>
+ </annotationProcessorPaths>
Review Comment:
```
activemq-artemis\artemis-quorum-ri>mvn dependency:tree -Derrorprone
[INFO] --- dependency:3.6.0:tree (default-cli) @ artemis-quorum-ri ---
[INFO] org.apache.activemq:artemis-quorum-ri:jar:2.30.0-SNAPSHOT
[INFO] +- org.apache.curator:curator-recipes:jar:5.2.0:compile
[INFO] | \- org.apache.curator:curator-framework:jar:5.2.0:compile
[INFO] +- org.apache.curator:curator-client:jar:5.2.0:compile
[INFO] | \- com.google.guava:guava:jar:27.0.1-jre:compile
[INFO] | +- com.google.guava:failureaccess:jar:1.0.1:compile
[INFO] | +-
com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:compile
[INFO] | +- org.checkerframework:checker-qual:jar:2.5.2:compile
[INFO] | +- com.google.j2objc:j2objc-annotations:jar:1.1:compile
[INFO] | \- org.codehaus.mojo:animal-sniffer-annotations:jar:1.17:compile
[INFO] +- org.apache.zookeeper:zookeeper:jar:3.6.3:compile
[INFO] | +- org.apache.zookeeper:zookeeper-jute:jar:3.6.3:compile
[INFO] | \- io.netty:netty-handler:jar:4.1.94.Final:compile
[INFO] | +- io.netty:netty-common:jar:4.1.94.Final:compile
[INFO] | +- io.netty:netty-resolver:jar:4.1.94.Final:compile
[INFO] | +-
io.netty:netty-transport-native-unix-common:jar:4.1.94.Final:compile
[INFO] | \- io.netty:netty-codec:jar:4.1.94.Final:compile
[INFO] +- org.apache.curator:curator-test:jar:5.2.0:test
[INFO] | +- io.dropwizard.metrics:metrics-core:jar:3.2.5:test
[INFO] | \- org.xerial.snappy:snappy-java:jar:1.1.7:test
[INFO] +- org.apache.activemq:artemis-quorum-api:jar:2.30.0-SNAPSHOT:compile
[INFO] +- org.slf4j:slf4j-api:jar:1.7.36:compile
[INFO] +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.20.0:test
[INFO] | +- org.apache.logging.log4j:log4j-api:jar:2.20.0:test
[INFO] | \- org.apache.logging.log4j:log4j-core:jar:2.20.0:test
[INFO] +- org.apache.activemq:artemis-commons:jar:2.30.0-SNAPSHOT:compile
[INFO] | +- io.netty:netty-buffer:jar:4.1.94.Final:compile
[INFO] | +- io.netty:netty-transport:jar:4.1.94.Final:compile
[INFO] | \- commons-beanutils:commons-beanutils:jar:1.9.4:compile
[INFO] | +- commons-logging:commons-logging:jar:1.2:compile
[INFO] | \- commons-collections:commons-collections:jar:3.2.2:compile
[INFO] +- junit:junit:jar:4.13.2:test
[INFO] | \- org.hamcrest:hamcrest-core:jar:1.3:test
[INFO] +-
org.apache.activemq:artemis-unit-test-support:jar:2.30.0-SNAPSHOT:test
[INFO] +- org.hamcrest:hamcrest:jar:2.1:test
[INFO] \- com.google.errorprone:error_prone_core:jar:2.20.0:provided
[INFO] +- com.google.errorprone:error_prone_annotation:jar:2.20.0:provided
[INFO] +-
com.google.errorprone:error_prone_type_annotations:jar:2.20.0:provided
[INFO] +- com.google.errorprone:error_prone_check_api:jar:2.20.0:provided
[INFO] | +- io.github.java-diff-utils:java-diff-utils:jar:4.0:provided
[INFO] | | \-
org.eclipse.jgit:org.eclipse.jgit:jar:4.4.1.201607150455-r:provided
[INFO] | +-
com.github.kevinstern:software-and-algorithms:jar:1.0:provided
[INFO] | +- com.github.ben-manes.caffeine:caffeine:jar:3.1.6:provided
[INFO] | \- com.google.inject:guice:jar:5.1.0:provided
[INFO] | \- aopalliance:aopalliance:jar:1.0:provided
[INFO] +- org.pcollections:pcollections:jar:3.1.4:provided
[INFO] +- com.google.auto:auto-common:jar:1.2.1:provided
[INFO] +- com.google.code.findbugs:jsr305:jar:3.0.2:compile
[INFO] +- io.github.eisop:dataflow-errorprone:jar:3.34.0-eisop1:provided
[INFO] +- com.google.auto.value:auto-value-annotations:jar:1.9:provided
[INFO] +- com.google.errorprone:error_prone_annotations:jar:2.20.0:compile
[INFO] +- com.google.protobuf:protobuf-java:jar:3.19.6:provided
[INFO] +-
com.google.auto.service:auto-service-annotations:jar:1.0.1:provided
[INFO] \- javax.inject:javax.inject:jar:1:provided
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
