clebertsuconic commented on code in PR #4567:
URL: https://github.com/apache/activemq-artemis/pull/4567#discussion_r1273736855


##########
pom.xml:
##########
@@ -1191,6 +1185,18 @@
                               
<arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED</arg>
                               
<arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED</arg>
                           </compilerArgs>
+                          <annotationProcessorPaths>
+                              <path>
+                                  <groupId>org.apache.activemq</groupId>
+                                  
<artifactId>artemis-log-annotation-processor</artifactId>
+                                  <version>${project.version}</version>
+                              </path>

Review Comment:
   hmmm... it will be difficult to maintain this down the road.
   
   you don't specify log-annotation-processor if not using errorprone, but if 
using, then you do...
   
   
   I won't know what's going in a few weeks from now.... a few months or an 
year for now and I have to debug anything this gets unpredictable, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to