gemmellr commented on code in PR #4565:
URL: https://github.com/apache/activemq-artemis/pull/4565#discussion_r1276299266
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Upgrade.java:
##########
@@ -106,8 +106,16 @@ public Object run(ActionContext context) throws Exception {
throw new IOException(etcFolder + " does not exist for etc");
}
+ StringBuffer javaOption = new StringBuffer();
Review Comment:
StringBuilder?
Name could be more obvious than the singular of the original plural list,
e.g javaOptionsArgs...or javaOptionsString (and build the value here rather
than later at the point it is passed, throw away the builder).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
