clebertsuconic commented on code in PR #4565: URL: https://github.com/apache/activemq-artemis/pull/4565#discussion_r1278011424
########## artemis-distribution/src/main/resources/bin/artemis: ########## @@ -91,6 +91,9 @@ if $cygwin ; then fi exec "$JAVACMD" $JAVA_ARGS $ARTEMIS_CLUSTER_PROPS \ + --add-opens java.base/java.lang=ALL-UNNAMED \ + --add-opens java.base/java.io=ALL-UNNAMED \ + --add-opens java.base/java.util=ALL-UNNAMED \ Review Comment: @gnodet I"m adding jline3 into artemis, integrated with pico-CLI. This PR is taking an example from the jline3 along with some examples I saw on pico-cli .. and I had to include these with JDK-11, while these are not needed in 17. I'm confused what I need to do to integrate this. can you help us here? ########## artemis-distribution/src/main/resources/bin/artemis: ########## @@ -91,6 +91,9 @@ if $cygwin ; then fi exec "$JAVACMD" $JAVA_ARGS $ARTEMIS_CLUSTER_PROPS \ + --add-opens java.base/java.lang=ALL-UNNAMED \ + --add-opens java.base/java.io=ALL-UNNAMED \ + --add-opens java.base/java.util=ALL-UNNAMED \ Review Comment: hmmmmmmm... I don't need these with JDK17. @gnodet it would be so nice to get your help here? :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
