gemmellr commented on code in PR #4573:
URL: https://github.com/apache/activemq-artemis/pull/4573#discussion_r1281614512
##########
artemis-website/pom.xml:
##########
@@ -29,24 +29,20 @@
<properties>
<activemq.basedir>${project.basedir}/..</activemq.basedir>
- <webapp-dir>${project.artifactId}-${project.version}</webapp-dir>
-
<src-dir-user-manual>${basedir}/../docs/user-manual/en</src-dir-user-manual>
-
<scratch-dir-user-manual>${basedir}/target/scratch/user-manual</scratch-dir-user-manual>
-
<webapp-outdir-user-manual>${basedir}/target/classes/user-manual</webapp-outdir-user-manual>
-
<webapp-outdir-hacking-guide>${basedir}/target/classes/hacking-guide</webapp-outdir-hacking-guide>
-
<webapp-outdir-migration-guide>${basedir}/target/classes/migration-guide</webapp-outdir-migration-guide>
-
- <frontend-maven-plugin-version>1.12.1</frontend-maven-plugin-version>
- <nodeVersion>v18.15.0</nodeVersion>
- <npmVersion>9.6.2</npmVersion>
+
<asciidoctor.maven.plugin.version>2.2.4</asciidoctor.maven.plugin.version>
+ <asciidoctorj.pdf.version>2.3.9</asciidoctorj.pdf.version>
<skipWebsiteDocGeneration>false</skipWebsiteDocGeneration>
<skipWebsiteJavadocGeneration>false</skipWebsiteJavadocGeneration>
+ <skipWebsitePdfGeneration>false</skipWebsitePdfGeneration>
+
+ <!-- these only need to be generated occasionally, not every release -->
+
<skipWebsiteMigrationGuideGeneration>true</skipWebsiteMigrationGuideGeneration>
+
<skipWebsiteHackingGuideGeneration>true</skipWebsiteHackingGuideGeneration>
Review Comment:
Not enabling them means they wont be in the produced output as they are
currently however, which is kind of nice to have the whole 'website docs
collection' from the point in time of the release.
Unless they are _really_ slow to produce (which they weren't before) it
would seem simpler just to generate them as before rather than having to
specify options to get things to build. I'd then also default these to the
skipWebsiteDocGeneration so existing usage skips all the docs as before.
Anyone wanting to mix-and-match can use the various properties explicitly to
get what they want if needed. Given they should be relatively quick to produce
I dont see anyone needing to bother with that, except maybe disabling PDF
generation and keeping the rest.
EDIT: To the starting jar content comment....actually turns out the module
jar no longer contains _any_ of the HTML output as before, presumably as it
isnt generated into the classes dir as before or otherwise added to the jar. So
it just has some metadata stuff but is otherwise empty.
We should either restore the jar contents so it is in line with previously,
or just stop deploying it entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
