jbertram commented on PR #4576: URL: https://github.com/apache/activemq-artemis/pull/4576#issuecomment-1671595848
This looks good. Thanks for the contribution! However, before merging this needs a couple of things... First, it needs an associated Jira. If you don't already have an Apache Jira account you can [request one](https://selfserve.apache.org/jira-account.html). I'll watch for your request and approve it ASAP. Once you create a Jira you should update the commit message to reference it. See more details about commit messages in our [Hacking Guide](https://github.com/apache/activemq-artemis/blob/main/docs/hacking-guide/_code.adoc#commitMessageDetails). Second, it needs a test to both validate the fix and also prevent regressions in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
