clebertsuconic commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1690415066
-1000 on this.. sorry!!! The whole point of the BundleFactory is not require knowing the implementation from the Interface, and having the Factory figuring out what to do. I don't mind about this reflection here as it's only happening once.. it's more trouble really. the framework where this came from is Jboss Logging, where we are doing exactly what it was done before, except that we did that to fix some licensing and to be able to use SLF4J. I hate to block a PR from someone but I strongly disagree with this one man! sorry about that! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
