jbertram commented on code in PR #4589:
URL: https://github.com/apache/activemq-artemis/pull/4589#discussion_r1303481917
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/security/impl/SecurityStoreImpl.java:
##########
@@ -424,26 +432,71 @@ private void
handleNoCacheLoginException(NoCacheLoginException e) {
logger.debug("Skipping authentication cache due to exception: {}",
e.getMessage());
}
+ private void putAuthenticationCacheEntry(String user,
+ String password,
+ RemotingConnection connection,
+ Subject subject) {
+ if (authenticationCache != null) {
+ authenticationCache.put(createAuthenticationCacheKey(user, password,
connection), new Pair<>(subject != null, subject));
+ }
+ }
+
+ private Pair<Boolean, Subject> getAuthenticationCacheEntry(String user,
+ String password,
+
RemotingConnection connection) {
+ if (authenticationCache == null) {
+ return null;
+ } else {
+ return
authenticationCache.getIfPresent(createAuthenticationCacheKey(user, password,
connection));
+ }
+ }
+
+ private void getAuthorizationCacheEntry(ConcurrentHashSet<SimpleString>
set, String key) {
Review Comment:
Indeed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
