gtully commented on code in PR #4590:
URL: https://github.com/apache/activemq-artemis/pull/4590#discussion_r1304632604
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/federation/address/FederatedAddress.java:
##########
@@ -310,10 +312,15 @@ private boolean match(AddressInfo addressInfo) {
}
private boolean match(SimpleString address, RoutingType routingType) {
- //Currently only supporting Multicast currently.
+ // only supporting Multicast currently.
if (RoutingType.ANYCAST.equals(routingType)) {
return false;
}
+ if (hasPullConnectionConfig) {
+ // multicast address federation has no local queue to trigger batch
pull requests, a regular fast consumer with credit window is necessary
+ // otherwise the upstream would fill up and block.
Review Comment:
thanks Tim, sure it won't hurt and could help. Can do the same for both
config error clauses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
