gemmellr commented on PR #4592: URL: https://github.com/apache/activemq-artemis/pull/4592#issuecomment-1693477310
I have made a somewhat-inbetween change in df410da7ae of adding tests for each of the log bundles such that, while still not doing what you proposed on #4582, it means each of the generated classes gets used by a particular unit test that will fail if they aren't generated, rather than relying on the existing more general client+broker tests that will already happen to fail. While doing that I also found your previous changes from #4580 had actually broken the AssertionLoggerHandler a little as it was indicating it found things that it had not, so I fixed that in https://github.com/apache/activemq-artemis/commit/6d4fad7a4c04f1ba96eb3d4fb3d55f6d86787780 and corrected one of the related test updates which then showed up as being incorrect by starting to fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
