gemmellr commented on PR #4584: URL: https://github.com/apache/activemq-artemis/pull/4584#issuecomment-1693527991
> > So I guess its just a case of deciding whether we want to retain the guava-style inline execution behaviour, or change to the Caffeine async execution default. > > Regarding the cache usage in `org.apache.activemq.artemis.core.security.impl.SecurityStoreImpl` my thoughts are: > > 1. The only use-case where it really matters is with size = 0 and that's been fixed that already via [ARTEMIS-4399 fix disabled authn/z cache #4589](https://github.com/apache/activemq-artemis/pull/4589). > > 2. It makes sense to optimize security since it is used basically every time a client connects. > > > Therefore, I'm in favor of using the default from Caffeine. Fair enough, since the SecurityStoreImpl doesnt look to use any of the listener stuff so it probably isn't really much/any different. The other usage does use it though, so I want to look into whether its prepared to handle the new concurrency that could result from offloading to the FJ pool (though if not, it may also not be prepared to handle any existing concurrency that could occur already.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
