cshannon commented on PR #1046: URL: https://github.com/apache/activemq/pull/1046#issuecomment-1744954362
Overall my impressions are that this seems more complicated than it appears to be at first glance because you need to properly handle rolling things back and making sure that in certain modes the client acts like the receive was never called. I am not sure that simply re-adding the message to the unconsumed list is enough. There's a lot of code in rollback() to handle things like duplicate detection so the message can be received again. So that being said I think this needs more work and a lot more testing and might need to wait for 6.1.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
