AntonRoskvist commented on PR #4644: URL: https://github.com/apache/activemq-artemis/pull/4644#issuecomment-1760242868
Yes, @clebertsuconic you are right, I missed that one... though looking closer at that test I'm actually getting a bit confused as to what the expected or intended behavior really should be... with ON_DEMAND semantics: First, given topic/multicast semantics for a single node: 10 messages are sent to an address with 10 multicast/topic queues results in: 10 messages end up on each queue, grand total of 100 messages. This aligns with my understanding of how topic/multicast semantics work. However, given the same scenario on a two node cluster: 10 messages sent to an address with 10 multicast/topic queues distributed over 2 nodes: The 10 messages gets distributed between the nodes, 5 each. 5 messages on each queue within a node, grand total of 50 messages. Is that the expected behavior? ...I'm also not 100% sure that the test is working as intended, and neither is OFF_WITH_REDISTRIBUTION, this PR or not. Probably the condition: ` if ( !Objects.equals(message.getRoutingType(), RoutingType.MULTICAST) ...` in BindingImpl#matchBinding should be removed or formulated differently to just rely on redistribution, not initial distribution, regardless of RoutingType... I will do some additional testing on this. Anyway, In the failing test (org.apache.activemq.artemis.tests.integration.amqp.connect.AMQPRedistributeClusterTest.testTopicRedistributionAMQP), when messages are sent there are no active consumers on any node and as such all messages _should_ end up on just the producers target node (or possibly all messages on all nodes?). This is what happens in the same test when switching over to ON_DEMAND load balancing as well... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
