gemmellr commented on code in PR #4652:
URL: https://github.com/apache/activemq-artemis/pull/4652#discussion_r1369819142
##########
tests/artemis-test-support/src/main/java/org/apache/activemq/artemis/utils/RealServerTestBase.java:
##########
@@ -93,6 +93,11 @@ public static String getServerLocation(String serverName) {
return basedir + "/target/" + serverName;
}
+ public static File getFileServerLocation(String serverName) {
+ return new File(getServerLocation(serverName));
+ }
+
+
Review Comment:
superfluous newline
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/SimpleManagement.java:
##########
@@ -98,6 +98,11 @@ public long getMessageCountOnQueue(String queueName) throws
Exception {
return simpleManagementLong(ResourceNames.QUEUE + queueName,
"getMessageCount");
}
+ public long getMessagesAddedOnQueue(String queueName) throws Exception {
+ return simpleManagementLong(ResourceNames.QUEUE + queueName,
"getMessagesAdded");
+ }
+
+
Review Comment:
superfluous newline
##########
tests/artemis-test-support/src/main/java/org/apache/activemq/artemis/utils/cliHelper/BaseCLI.java:
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.utils.cliHelper;
+
+import java.io.File;
+import java.lang.invoke.MethodHandles;
+
+import org.junit.Assert;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class BaseCLI {
+
+ private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ BaseCLI() {
+ String propertyHome = System.getProperty("artemis.distribution.output");
+ if (propertyHome != null) {
+ artemisHome = new File(propertyHome);
+ }
+ logger.debug("using artemisHome as {}", artemisHome);
+ Assert.assertNotNull(artemisHome);
Review Comment:
Would be clearer to assert earlier before logging it. Could move to right
after property retrieval that would be null originally and then also drop the
null check.
##########
tests/artemis-test-support/src/main/java/org/apache/activemq/artemis/utils/cliHelper/BaseCLI.java:
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.utils.cliHelper;
+
+import java.io.File;
+import java.lang.invoke.MethodHandles;
+
+import org.junit.Assert;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class BaseCLI {
+
+ private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ BaseCLI() {
+ String propertyHome = System.getProperty("artemis.distribution.output");
+ if (propertyHome != null) {
+ artemisHome = new File(propertyHome);
+ }
+ logger.debug("using artemisHome as {}", artemisHome);
+ Assert.assertNotNull(artemisHome);
+ Assert.assertTrue(artemisHome.exists());
+ Assert.assertTrue(new File(artemisHome, "/bin").exists());
+ Assert.assertTrue(new File(artemisHome, "/bin/artemis").exists());
+
Review Comment:
Superfluous newline.
##########
tests/soak-tests/src/test/java/org/apache/activemq/artemis/tests/soak/replicationflow/ReplicationFlowControlTest.java:
##########
@@ -45,6 +47,63 @@ public class ReplicationFlowControlTest extends SoakTestBase
{
public static final String SERVER_NAME_0 = "replicated-static0";
public static final String SERVER_NAME_1 = "replicated-static1";
+ /*
+ <execution>
+ <phase>test-compile</phase>
+ <id>created-static0</id>
+ <goals>
+ <goal>create</goal>
+ </goals>
+ <configuration>
+ <!-- this makes it easier in certain envs -->
+ <javaOptions>-Djava.net.preferIPv4Stack=true</javaOptions>
+ <instance>${basedir}/target/replicated-static0</instance>
+
<configuration>${basedir}/target/classes/servers/replicated-static0</configuration>
+ </configuration>
+ </execution>
+ <execution>
+ <phase>test-compile</phase>
+ <id>create-replicated-static1</id>
+ <goals>
+ <goal>create</goal>
+ </goals>
+ <configuration>
+ <!-- this makes it easier in certain envs -->
+ <javaOptions>-Djava.net.preferIPv4Stack=true</javaOptions>
+ <instance>${basedir}/target/replicated-static1</instance>
+
<configuration>${basedir}/target/classes/servers/replicated-static1</configuration>
+ <args>
+ <arg>--java-options</arg>
+ <arg>-ea</arg>
+ </args>
+ </configuration>
+ </execution>
+ */
Review Comment:
Commented out pom snippet...remove?
##########
tests/artemis-test-support/src/main/java/org/apache/activemq/artemis/utils/cliHelper/BaseCLI.java:
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.utils.cliHelper;
+
+import java.io.File;
+import java.lang.invoke.MethodHandles;
+
+import org.junit.Assert;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class BaseCLI {
+
+ private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ BaseCLI() {
+ String propertyHome = System.getProperty("artemis.distribution.output");
+ if (propertyHome != null) {
+ artemisHome = new File(propertyHome);
+ }
+ logger.debug("using artemisHome as {}", artemisHome);
+ Assert.assertNotNull(artemisHome);
+ Assert.assertTrue(artemisHome.exists());
+ Assert.assertTrue(new File(artemisHome, "/bin").exists());
+ Assert.assertTrue(new File(artemisHome, "/bin/artemis").exists());
+
+ }
+
+
+ File artemisHome;
+ File artemisInstance;
+
+ public File getArtemisHome() {
+ return artemisHome;
+ }
+
+ public BaseCLI setArtemisHome(File artemisHome) {
+ this.artemisHome = artemisHome;
+ return this;
+ }
+
+ public File getArtemisInstance() {
+ return artemisInstance;
+ }
+
+ public BaseCLI setArtemisInstance(File artemisInstance) {
+ this.artemisInstance = artemisInstance;
+ return this;
+ }
+
+ public String[] getArgs() {
+ return args;
+ }
+
+ public BaseCLI setArgs(String... args) {
+
+ this.args = args;
+ return this;
+ }
+
+ String[] args = new String[0];
Review Comment:
Put fields before constructor?
##########
tests/artemis-test-support/src/main/java/org/apache/activemq/artemis/utils/cliHelper/CLICreate.java:
##########
@@ -0,0 +1,385 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.utils.cliHelper;
+
+import java.io.File;
+import java.io.IOException;
+import java.lang.invoke.MethodHandles;
+import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.StandardCopyOption;
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.activemq.artemis.cli.Artemis;
+import org.junit.Assert;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class CLICreate extends BaseCLI {
+
+ public CLICreate() {
+ super();
+ }
Review Comment:
Put constructor after fields?
Meta-comment, would be nice if we didnt need to basically implement a CLI to
use the existing CLI ;)
##########
tests/artemis-test-support/src/main/java/org/apache/activemq/artemis/utils/cliHelper/BaseCLI.java:
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.utils.cliHelper;
+
+import java.io.File;
+import java.lang.invoke.MethodHandles;
+
+import org.junit.Assert;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class BaseCLI {
+
+ private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ BaseCLI() {
+ String propertyHome = System.getProperty("artemis.distribution.output");
+ if (propertyHome != null) {
+ artemisHome = new File(propertyHome);
+ }
+ logger.debug("using artemisHome as {}", artemisHome);
+ Assert.assertNotNull(artemisHome);
+ Assert.assertTrue(artemisHome.exists());
+ Assert.assertTrue(new File(artemisHome, "/bin").exists());
+ Assert.assertTrue(new File(artemisHome, "/bin/artemis").exists());
+
+ }
+
+
+ File artemisHome;
+ File artemisInstance;
+
+ public File getArtemisHome() {
+ return artemisHome;
+ }
+
+ public BaseCLI setArtemisHome(File artemisHome) {
+ this.artemisHome = artemisHome;
+ return this;
+ }
+
+ public File getArtemisInstance() {
+ return artemisInstance;
+ }
+
+ public BaseCLI setArtemisInstance(File artemisInstance) {
+ this.artemisInstance = artemisInstance;
+ return this;
+ }
+
+ public String[] getArgs() {
+ return args;
+ }
+
+ public BaseCLI setArgs(String... args) {
+
Review Comment:
superfluous newline
##########
tests/artemis-test-support/src/main/java/org/apache/activemq/artemis/utils/cliHelper/BaseCLI.java:
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.utils.cliHelper;
+
+import java.io.File;
+import java.lang.invoke.MethodHandles;
+
+import org.junit.Assert;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class BaseCLI {
+
+ private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ BaseCLI() {
+ String propertyHome = System.getProperty("artemis.distribution.output");
+ if (propertyHome != null) {
+ artemisHome = new File(propertyHome);
+ }
+ logger.debug("using artemisHome as {}", artemisHome);
+ Assert.assertNotNull(artemisHome);
+ Assert.assertTrue(artemisHome.exists());
+ Assert.assertTrue(new File(artemisHome, "/bin").exists());
+ Assert.assertTrue(new File(artemisHome, "/bin/artemis").exists());
+
+ }
+
+
Review Comment:
Ditto
##########
tests/artemis-test-support/src/main/java/org/apache/activemq/artemis/utils/cliHelper/BaseCLI.java:
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.utils.cliHelper;
+
+import java.io.File;
+import java.lang.invoke.MethodHandles;
+
+import org.junit.Assert;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class BaseCLI {
+
+ private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ BaseCLI() {
+ String propertyHome = System.getProperty("artemis.distribution.output");
+ if (propertyHome != null) {
+ artemisHome = new File(propertyHome);
+ }
+ logger.debug("using artemisHome as {}", artemisHome);
+ Assert.assertNotNull(artemisHome);
+ Assert.assertTrue(artemisHome.exists());
+ Assert.assertTrue(new File(artemisHome, "/bin").exists());
+ Assert.assertTrue(new File(artemisHome, "/bin/artemis").exists());
+
+ }
+
+
+ File artemisHome;
+ File artemisInstance;
Review Comment:
Put fields before constructor?
##########
tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/console/ConsoleMutualSSLTest.java:
##########
@@ -41,6 +43,33 @@ public class ConsoleMutualSSLTest extends SmokeTestBase {
protected static final String SERVER_ADMIN_USERNAME = "admin";
protected static final String SERVER_ADMIN_PASSWORD = "admin";
+ @BeforeClass
+ public static void createServers() throws Exception {
+
+ {
Review Comment:
Superfluous newline. Is the block inside the method really needed?
##########
tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/expire/TestSimpleExpire.java:
##########
@@ -44,45 +61,52 @@ public void before() throws Exception {
@Test
public void testSendExpire() throws Exception {
+ final long NUMBER_EXPIRED = 1000;
+ final long NUMBER_NON_EXPIRED = 500;
ConnectionFactory factory = new
JmsConnectionFactory("amqp://localhost:61616");
- Connection connection = factory.createConnection();
- Session session = connection.createSession(true,
Session.SESSION_TRANSACTED);
-
- Queue queue = session.createQueue("q0");
- MessageProducer producer = session.createProducer(queue);
- producer.setDeliveryMode(DeliveryMode.PERSISTENT);
-
- producer.setTimeToLive(1000);
- for (int i = 0; i < 20000; i++) {
- producer.send(session.createTextMessage("expired"));
- if (i % 5000 == 0) {
- session.commit();
- System.out.println("Sent " + i + " + messages");
+ try (Connection connection = factory.createConnection()) {
+ Session session = connection.createSession(true,
Session.SESSION_TRANSACTED);
+
+ Queue queue = session.createQueue("q0");
+ MessageProducer producer = session.createProducer(queue);
+ producer.setDeliveryMode(DeliveryMode.PERSISTENT);
+
+ producer.setTimeToLive(100);
+ for (int i = 0; i < NUMBER_EXPIRED; i++) {
+ producer.send(session.createTextMessage("expired"));
+ if (i % 100 == 0) {
+ session.commit();
+ System.out.println("Sent " + i + " + messages");
+ }
+
}
- }
+ session.commit();
- session.commit();
- Thread.sleep(5000);
- producer.setTimeToLive(0);
- for (int i = 0; i < 500; i++) {
- producer.send(session.createTextMessage("ok"));
+ Thread.sleep(500);
+ producer.setTimeToLive(0);
+ for (int i = 0; i < 500; i++) {
+ producer.send(session.createTextMessage("ok"));
- }
- session.commit();
+ }
+ session.commit();
- MessageConsumer consumer = session.createConsumer(queue);
- connection.start();
+ MessageConsumer consumer = session.createConsumer(queue);
+ connection.start();
+ for (int i = 0; i < NUMBER_NON_EXPIRED; i++) {
+ TextMessage txt = (TextMessage) consumer.receive(10000);
+ Assert.assertNotNull(txt);
+ Assert.assertEquals("ok", txt.getText());
+ }
+ Assert.assertNull(consumer.receiveNoWait());
- for (int i = 0; i < 500; i++) {
- TextMessage txt = (TextMessage) consumer.receive(10000);
- Assert.assertNotNull(txt);
- Assert.assertEquals("ok", txt.getText());
+ session.commit();
}
- session.commit();
+ /*SimpleManagement simpleManagement = new
SimpleManagement("tcp://localhost:61616", null, null);
+ Wait.assertEquals(NUMBER_EXPIRED, () ->
simpleManagement.getMessageCountOnQueue("ExpiryQueue"), 5000, 100); */
Review Comment:
commented out code, fix or remove?
##########
tests/smoke-tests/pom.xml:
##########
@@ -1376,168 +407,7 @@
</args>
</configuration>
</execution>
- <execution>
- <phase>test-compile</phase>
- <id>create-jdbc-bad-driver</id>
- <goals>
- <goal>create</goal>
- </goals>
- <configuration>
- <role>amq</role>
- <user>admin</user>
- <password>admin</password>
- <allowAnonymous>false</allowAnonymous>
- <noWeb>true</noWeb>
- <instance>${basedir}/target/jdbc-bad-driver</instance>
- <args>
- <arg>--http-host</arg>
- <arg>${sts-http-host}</arg>
- <arg>--http-port</arg>
- <arg>8161</arg>
- <arg>--shared-store</arg>
- <arg>--jdbc</arg>
- <arg>--jdbc-connection-url</arg>
- <arg>tcp://noexist</arg>
- <arg>--jdbc-driver-class-name</arg>
- <arg>badDriver</arg>
- </args>
- </configuration>
- </execution>
- <execution>
- <phase>test-compile</phase>
- <id>create-test-Mirror1</id>
- <goals>
- <goal>create</goal>
- </goals>
- <configuration>
- <role>amq</role>
- <user>admin</user>
- <password>admin</password>
- <allowAnonymous>true</allowAnonymous>
- <noWeb>true</noWeb>
-
<instance>${basedir}/target/mirrored-subscriptions/broker1</instance>
-
<configuration>${basedir}/target/classes/servers/mirrored-subscriptions/broker1</configuration>
- </configuration>
- </execution>
- <execution>
- <phase>test-compile</phase>
- <id>create-test-Mirror2</id>
- <goals>
- <goal>create</goal>
- </goals>
- <configuration>
- <role>amq</role>
- <user>admin</user>
- <password>admin</password>
- <allowAnonymous>true</allowAnonymous>
- <noWeb>true</noWeb>
-
<instance>${basedir}/target/mirrored-subscriptions/broker2</instance>
-
<configuration>${basedir}/target/classes/servers/mirrored-subscriptions/broker2</configuration>
- </configuration>
- </execution>
- <execution>
- <phase>test-compile</phase>
- <id>create-topology-check-one</id>
- <goals>
- <goal>create</goal>
- </goals>
- <configuration>
- <role>amq</role>
- <user>admin</user>
- <password>admin</password>
- <allowAnonymous>false</allowAnonymous>
- <noWeb>false</noWeb>
- <clustered>true</clustered>
-
<instance>${basedir}/target/topology-check/broker1</instance>
-
<configuration>${basedir}/target/classes/servers/topology-check/broker1</configuration>
- </configuration>
- </execution>
- <execution>
- <phase>test-compile</phase>
- <id>create-topology-check-two</id>
- <goals>
- <goal>create</goal>
- </goals>
- <configuration>
- <role>amq</role>
- <user>admin</user>
- <password>admin</password>
- <portOffset>1</portOffset>
- <allowAnonymous>false</allowAnonymous>
- <noWeb>false</noWeb>
- <clustered>true</clustered>
-
<instance>${basedir}/target/topology-check/broker2</instance>
-
<configuration>${basedir}/target/classes/servers/topology-check/broker2</configuration>
- </configuration>
- </execution>
- <execution>
- <phase>test-compile</phase>
- <id>create-topology-check-three</id>
- <goals>
- <goal>create</goal>
- </goals>
- <configuration>
- <role>amq</role>
- <user>admin</user>
- <password>admin</password>
- <portOffset>2</portOffset>
- <allowAnonymous>false</allowAnonymous>
- <noWeb>false</noWeb>
- <clustered>true</clustered>
-
<instance>${basedir}/target/topology-check/broker3</instance>
-
<configuration>${basedir}/target/classes/servers/topology-check/broker3</configuration>
- </configuration>
- </execution>
- <execution>
- <phase>test-compile</phase>
- <id>create-topology-check-four</id>
- <goals>
- <goal>create</goal>
- </goals>
- <configuration>
- <role>amq</role>
- <user>admin</user>
- <password>admin</password>
- <portOffset>3</portOffset>
- <allowAnonymous>false</allowAnonymous>
- <noWeb>false</noWeb>
- <clustered>true</clustered>
-
<instance>${basedir}/target/topology-check/broker4</instance>
-
<configuration>${basedir}/target/classes/servers/topology-check/broker4</configuration>
- </configuration>
- </execution>
- <execution>
- <id>create-check-test-live</id>
- <goals>
- <goal>create</goal>
- </goals>
- <configuration>
- <instance>${basedir}/target/check-test/live</instance>
- <sharedStore>true</sharedStore>
- <slave>false</slave>
- <dataFolder>${basedir}/target/check-test/data</dataFolder>
- <failoverOnShutdown>true</failoverOnShutdown>
- <staticCluster>tcp://localhost:61716</staticCluster>
- </configuration>
- </execution>
- <execution>
- <id>create-check-test-backup</id>
- <goals>
- <goal>create</goal>
- </goals>
- <configuration>
- <!-- this makes it easier in certain envs -->
- <javaOptions>-Djava.net.preferIPv4Stack=true</javaOptions>
- <instance>${basedir}/target/check-test/backup</instance>
- <sharedStore>true</sharedStore>
- <slave>true</slave>
- <dataFolder>${basedir}/target/check-test/data</dataFolder>
- <failoverOnShutdown>true</failoverOnShutdown>
- <portOffset>100</portOffset>
- <staticCluster>tcp://localhost:61616</staticCluster>
- </configuration>
- </execution>
- <execution>
+ <execution>
Review Comment:
indentation looks off
##########
tests/artemis-test-support/src/main/java/org/apache/activemq/artemis/utils/cliHelper/BaseCLI.java:
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.utils.cliHelper;
Review Comment:
Perhaps _.cli.helper_ rather than the cliHelper camelCase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
