gemmellr commented on PR #4657: URL: https://github.com/apache/activemq-artemis/pull/4657#issuecomment-1781894403
Comparing the 2.31.0 and 2.31.1 jars, the key difference looks like being that the former didnt have any services file at all, while the latter now has an incorrect one as it references the non-shaded class that then isnt present. Given I believe the original reason for shading it was to have an 'internal, not-javax, not-jakarta' impl, its unclear to me that it should be registering it at all, which is what this change would presumably do once again by correcting the class name...so I'm not sure its the correct change? Excluding the services file again looks like it could be preferable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
