cshannon commented on code in PR #1123:
URL: https://github.com/apache/activemq/pull/1123#discussion_r1400927133
##########
activemq-ra/src/main/java/org/apache/activemq/ra/ActiveMQActivationSpec.java:
##########
@@ -147,25 +147,19 @@ public void validate() throws InvalidPropertyException {
}
public boolean isValidUseRAManagedTransaction(List<String> errorMessages) {
- try {
- new Boolean(useRAManagedTransaction);
- return true;
- } catch (Throwable e) {
- //
+ boolean retVal = Boolean.valueOf(useRAManagedTransaction);
+ if(!retVal) {
+ errorMessages.add("useRAManagedTransaction must be set to: true or
false.");
}
- errorMessages.add("useRAManagedTransaction must be set to: true or
false.");
Review Comment:
This seems wrong as this will add an error message even for "false"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
