jbertram commented on code in PR #4678:
URL: https://github.com/apache/activemq-artemis/pull/4678#discussion_r1406458780
##########
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java:
##########
@@ -137,11 +138,11 @@ public class MQTTUtil {
public static final int DEFAULT_MAXIMUM_PACKET_SIZE = MAX_PACKET_SIZE;
- public static String convertMqttTopicFilterToCoreAddress(String filter,
WildcardConfiguration wildcardConfiguration) {
- return convertMqttTopicFilterToCoreAddress(null, filter,
wildcardConfiguration);
+ public static String convertMqttTopicFilterToCore(String filter,
WildcardConfiguration wildcardConfiguration) {
+ return convertMqttTopicFilterToCore(null, filter, wildcardConfiguration);
}
- public static String convertMqttTopicFilterToCoreAddress(String
prefixToAdd, String filter, WildcardConfiguration wildcardConfiguration) {
Review Comment:
I changed the name because that method is used to convert the name of more
than just the address. It's used to convert the queue name as well. I shortened
it rather than making it something like
`convertMqttTopicFilterToCoreAddressOrQueue`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
