ehsavoie commented on code in PR #4712:
URL: https://github.com/apache/activemq-artemis/pull/4712#discussion_r1439227525
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/NettyConnectorTest.java:
##########
@@ -60,4 +64,35 @@ public void testConnectionTimeoutConfig() throws Exception {
factory.close();
locator.close();
}
+
+ @Test
+ public void testConnectionHttpHeaders() throws Exception {
+ TransportConfiguration transport = new
TransportConfiguration(NETTY_CONNECTOR_FACTORY);
+ transport.getParams().put(TransportConstants.HTTP_ENABLED_PROP_NAME,
true);
+ transport.getParams().put("netty.http.header.accept",
"text/html,application/xhtml+xml,application/xml");
+ transport.getParams().put("netty.http.header.Accept-Encoding",
"gzip,deflate");
+ transport.getParams().put("netty.http.header.Accept-Language",
"en-us,en;q=0.5");
Review Comment:
I humbly disagree so that if the constant changes it impacts the tests and
thus we know that this change can have a big impact
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
