gemmellr commented on code in PR #2:
URL:
https://github.com/apache/activemq-artemis-examples/pull/2#discussion_r1440306458
##########
examples/features/standard/interceptor-client/pom.xml:
##########
@@ -36,11 +36,6 @@ under the License.
</properties>
<dependencies>
- <dependency>
- <groupId>org.apache.activemq.examples.broker</groupId>
- <artifactId>interceptor</artifactId>
- <version>${project.version}</version>
- </dependency>
Review Comment:
Since this was removed without adding anything...does it just mean this
example doesnt _actually_ depend on the other one, but its just mistakenly said
it did all this time?
##########
examples/features/standard/interceptor-client/pom.xml:
##########
@@ -60,7 +55,7 @@ under the License.
<goal>create</goal>
</goals>
<configuration>
-
<libList><arg>org.apache.activemq.examples.broker:interceptor:${project.version}</arg></libList>
+
<libList><arg>org.apache.activemq.examples.broker:interceptor-client:${project.version}</arg></libList>
Review Comment:
Should this be needed here at all, if its actually a client-side example?
This bit being for creating the broker used. So cant this just be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
