jbertram commented on code in PR #4728:
URL: https://github.com/apache/activemq-artemis/pull/4728#discussion_r1445082085
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/HAPolicyConfiguration.java:
##########
@@ -21,14 +21,14 @@
public interface HAPolicyConfiguration extends Serializable {
enum TYPE {
- LIVE_ONLY("Live Only"),
+ PRIMARY_ONLY("Primary Only"),
REPLICATED("Replicated"),
REPLICA("Replica"),
- SHARED_STORE_MASTER("Shared Store Master"),
- SHARED_STORE_SLAVE("Shared Store Slave"),
+ SHARED_STORE_PRIMARY("Shared Store Primary"),
+ SHARED_STORE_BACKUP("Shared Store Backup"),
COLOCATED("Colocated"),
- PRIMARY("Primary"),
- BACKUP("Backup");
+ REPLICATION_PRIMARY("Replication Primary w/pluggable quorum voting"),
+ REPLICATION_BACKUP("Replication Backup w/pluggable quorum voting");
Review Comment:
I agree. I'm working on a follow-up PR that deals more with HA naming issues
like this in both the documentation and the code. At this point I think this PR
should be merged as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
