gemmellr commented on code in PR #4731:
URL: https://github.com/apache/activemq-artemis/pull/4731#discussion_r1446337356
##########
artemis-docker/prepare-docker.sh:
##########
@@ -53,23 +53,23 @@ Well done! Now you can continue with building the Docker
image:
# Go to $ARTEMIS_DIST_DIR
$ cd $ARTEMIS_DIST_DIR
- # For CentOS with full JDK 11
- $ docker build -f ./docker/Dockerfile-centos7-11 -t artemis-centos .
+ # For CentOS with full JDK 17
+ $ docker build -f ./docker/Dockerfile-centos7-17 -t artemis-centos .
- # For Ubuntu with full JDK 11
- $ docker build -f ./docker/Dockerfile-ubuntu-11 -t artemis-ubuntu .
+ # For Ubuntu with full JDK 21
+ $ docker build -f ./docker/Dockerfile-ubuntu-21 -t artemis-ubuntu .
- # For Ubuntu with just JRE 11
- $ docker build -f ./docker/Dockerfile-ubuntu-11-jre -t artemis-ubuntu-jre .
+ # For Ubuntu with just JRE 21
+ $ docker build -f ./docker/Dockerfile-ubuntu-21-jre -t artemis-ubuntu-jre .
- # For Alpine with full JDK 17
- $ docker build -f ./docker/Dockerfile-alpine-17 -t artemis-alpine .
+ # For Alpine with full JDK 21
+ $ docker build -f ./docker/Dockerfile-alpine-21 -t artemis-alpine .
- # For Alpine with just JRE 11
- $ docker build -f ./docker/Dockerfile-alpine-11-jre -t artemis-alpine-jre .
+ # For Alpine with just JRE 21
+ $ docker build -f ./docker/Dockerfile-alpine-21-jre -t artemis-alpine-jre .
- # For Ubuntu on Linux ARMv7/ARM64 with full JDK
- $ docker buildx build --platform linux/arm64,linux/arm/v7 --push -t
{your-repository}/apache-artemis:2.17.0-SNAPSHOT -f
./docker/Dockerfile-ubuntu-11 .
+ # Multi-platform for Ubuntu on Linux AMD64 & ARM64/V8 with full JDK
+ $ docker buildx build --platform linux/amd64,linux/arm64/v8 --push -t
{your-repository}/apache-artemis:{your-version} -f
./docker/Dockerfile-ubuntu-21 .
Review Comment:
Think the ARM bits should just be ARM64 and linux/arm64, i.e. left as it
was to start with rather than changed to ARM64/V8 and linux/arm64/v8, looking
at examples from
https://docs.docker.com/build/building/multi-platform/#cross-compilation
```suggestion
# Multi-platform for Ubuntu on Linux AMD64 & ARM64 with full JDK
$ docker buildx build --platform linux/amd64,linux/arm64 --push -t
{your-repository}/apache-artemis:{your-version} -f
./docker/Dockerfile-ubuntu-21 .
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
