gemmellr commented on code in PR #4738: URL: https://github.com/apache/activemq-artemis/pull/4738#discussion_r1449150778
########## .gitignore: ########## @@ -33,3 +33,5 @@ artemis-native/src/main/c/org_apache_activemq_artemis_jlibaio_LibaioContext.h # overlay outpit **/overlays/**/* + +artemis-docker/_TMP_ Review Comment: Could you use the target directory instead of _TMP_? That way it would be more consistent with other modules and not need a separate exclusion here? (...and perhaps elsewhere.. e.g doing a source assembly creation would presumably still pick this stuff up, but wouldn't need special handling to skip use of target). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
