brusdev commented on code in PR #4729:
URL: https://github.com/apache/activemq-artemis/pull/4729#discussion_r1453038703
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/routing/ConnectionRouterConfiguration.java:
##########
@@ -26,8 +26,8 @@ public class ConnectionRouterConfiguration implements
Serializable {
private KeyType keyType = KeyType.SOURCE_IP;
private String keyFilter = null;
private String localTargetFilter = null;
- private CacheConfiguration cacheConfiguration = null;
- private PoolConfiguration poolConfiguration = null;
+ private CacheConfiguration cacheConfiguration = new
CacheConfiguration().setEnabled(false);
+ private PoolConfiguration poolConfiguration = new
PoolConfiguration().setEnabled(false);
Review Comment:
I reverted the default value of the `enabled` bit for cache and pool
configurations to true but I keep the xml attribute `enabled` suggested by
@tabish121. The 3 different ways of configuring things seem more consistent:
- xml: the `connection-router` element has no cache or pool enabled by
default but if you create a cache or pool element they are enabled by default
(this is important for backward compatibility)
- programmatically: the `ConnectionRouterConfiguration` class has no cache
or pool enabled by default but if you create a CacheConfiguration or
PoolConfiguration class they are enabled by default (this is important for
backward compatibility)
- broker properties: the `connectionRouters` items have no cache or pool
enabled by default but you can set enabled to true to enable them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
