tabish121 commented on code in PR #4743: URL: https://github.com/apache/activemq-artemis/pull/4743#discussion_r1456114078
########## artemis-commons/src/main/java/org/apache/activemq/artemis/utils/runnables/RunnableList.java: ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.activemq.artemis.utils.runnables; + +import java.util.HashSet; +import java.util.function.Consumer; + +public class RunnableList { + + private final HashSet<AtomicRunnable> list = new HashSet<>(); + + public RunnableList() { + } + + public synchronized void add(AtomicRunnable runnable) { + runnable.setAcceptedList(this); + list.add(runnable); + } + + public int size() { + return list.size(); + } + + public synchronized void remove(AtomicRunnable runnable) { + list.remove(runnable); + } + + public void afterRun(AtomicRunnable runnable) { Review Comment: What is the purpose of this method as opposed to just calling the remove method directly as this method does, would seem to be more descriptive for the callers to invoke remove plus remove is directly declared as synchronized which seems the point of the atomic types being implemented. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
