gemmellr commented on code in PR #4746:
URL: https://github.com/apache/activemq-artemis/pull/4746#discussion_r1457309493
##########
etc/checkstyle.xml:
##########
@@ -100,14 +100,15 @@ under the License.
<property name="severity" value="ignore"/>
</module>
- <!-- Sevntu checks,
http://sevntu-checkstyle.github.io/sevntu.checkstyle/ -->
- <module name="DiamondOperatorForVariableDefinition"/>
<module name="RequiredParameterForAnnotation">
<property name="annotationName" value="Parameterized.Parameters"/>
<property name="requiredParameters" value="name"/>
</module>
<module name="UnnecessarySemicolonInTryWithResources"/>
+ <!-- Sevntu checks,
http://sevntu-checkstyle.github.io/sevntu.checkstyle/ -->
+ <module name="DiamondOperatorForVariableDefinition"/>
Review Comment:
The comment seems potentially out of place now since e.g
RequiredParameterForAnnotation also looks to be a Sevntu check? Did this need
moved?
##########
pom.xml:
##########
@@ -1750,10 +1749,16 @@
<artifactId>jacoco-maven-plugin</artifactId>
<version>${version.org.jacoco.plugin}</version>
</plugin>
+ <plugin>
+ <!-- This is needed until
https://issues.apache.org/jira/browse/MSHADE-462 is resolved. Once that is
+ done then we can inherit the version from the Apache
parent POM. -->
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <version>3.4.1</version>
+ </plugin>
Review Comment:
You can just set (i.e override) the property they used in the parent
dependencyManagement to the desired version, rather than add the full config
and hard-coded version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
