gemmellr commented on code in PR #4749:
URL: https://github.com/apache/activemq-artemis/pull/4749#discussion_r1457437316
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java:
##########
@@ -2357,11 +2357,19 @@ public synchronized RoutingStatus doSend(final
Transaction tx,
routingContext.setAddress(art.getName());
routingContext.setRoutingType(art.getRoutingType());
+ // Retrieve message size for metrics update before routing,
+ // since large message backing files may be closed once routing
completes
+ int lmSize = 0;
Review Comment:
variable name needs updated (here and in updateProducerMetrics), lmSize
doesnt make sense now
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java:
##########
@@ -2357,11 +2357,19 @@ public synchronized RoutingStatus doSend(final
Transaction tx,
routingContext.setAddress(art.getName());
routingContext.setRoutingType(art.getRoutingType());
+ // Retrieve message size for metrics update before routing,
+ // since large message backing files may be closed once routing
completes
+ int lmSize = 0;
Review Comment:
variable name needs updated (here and in updateProducerMetrics), _lmSize_
doesnt make sense now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
