gemmellr commented on code in PR #4741:
URL: https://github.com/apache/activemq-artemis/pull/4741#discussion_r1458656430
##########
tests/compatibility-tests/pom.xml:
##########
@@ -337,6 +337,8 @@
<arg>org.apache.activemq:artemis-server:${project.version}</arg>
<arg>org.apache.activemq:artemis-journal:${project.version}</arg>
<arg>org.apache.activemq:artemis-hornetq-protocol:${project.version}</arg>
+
<arg>org.apache.activemq:artemis-jakarta-openwire-protocol:${project.version}</arg>
+
<arg>org.apache.logging.log4j:log4j-slf4j2-impl:2.21.1</arg>
Review Comment:
This should use the version property to pick up the appropriate version the
codebase is using.
##########
tests/compatibility-tests/pom.xml:
##########
@@ -686,6 +688,7 @@
<optional>true</optional>
<libListWithDeps>
<arg>org.apache.activemq:activemq-client:5.11.0</arg>
+
<arg>org.apache.logging.log4j:log4j-slf4j2-impl:2.21.1</arg>
Review Comment:
Ditto (for the log4j bit)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
