clebertsuconic commented on code in PR #4752:
URL: https://github.com/apache/activemq-artemis/pull/4752#discussion_r1462333062
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ScheduledDeliveryHandlerImpl.java:
##########
@@ -51,10 +51,13 @@ public class ScheduledDeliveryHandlerImpl implements
ScheduledDeliveryHandler {
// This contains RefSchedules which are delegates to the real references
// just adding some information to keep it in order accordingly to the
initial operations
+ // Do not forget to call notifyScheduledReferencesUpdated() when updating
the set.
Review Comment:
if you apply my suggestion please remove these calls..
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ScheduledDeliveryHandlerImpl.java:
##########
@@ -51,10 +51,13 @@ public class ScheduledDeliveryHandlerImpl implements
ScheduledDeliveryHandler {
// This contains RefSchedules which are delegates to the real references
// just adding some information to keep it in order accordingly to the
initial operations
+ // Do not forget to call notifyScheduledReferencesUpdated() when updating
the set.
private final TreeSet<RefScheduled> scheduledReferences = new TreeSet<>(new
MessageReferenceComparator());
private final QueueMessageMetrics metrics;
+ private MessageReference oldestMessage = null;
Review Comment:
remove this upon accepting my suggestion.. (and please squash the change as
yours)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
