gaohoward commented on code in PR #4756:
URL: https://github.com/apache/activemq-artemis/pull/4756#discussion_r1462645056


##########
tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/paging/impl/PagingStoreImplTest.java:
##########
@@ -1252,6 +1252,7 @@ public void run() {
          };
          store.applySetting(new 
AddressSettings().setMaxSizeBytes(1000).setAddressFullMessagePolicy(AddressFullMessagePolicy.BLOCK));
          store.addSize(100);
+         store.flushExecutors();
          store.checkMemory(trackMemoryChecks, null);
          assertEquals(1, calls.get());

Review Comment:
   The wait may not work well for example here waiting for zero "0" would not 
prevent the task being fired later as it's init state is 0. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to