gemmellr commented on code in PR #4760:
URL: https://github.com/apache/activemq-artemis/pull/4760#discussion_r1479757997
##########
docs/user-manual/web-server.adoc:
##########
@@ -43,6 +43,8 @@ The minimum number of threads the embedded web server will
hold to service HTTP
Default is `8` or the value of `maxThreads` if it is lower.
idleThreadTimeout::
The time to wait before terminating an idle thread from the embedded web
server. Measured in milliseconds. Default is `60000`.
+scanPeriod::
+How often to scan for file changes. Measured in seconds. Default is `5`.
Review Comment:
Think this could be clearer. The TLS reload it only happens if the other
setting is enabled, which it isnt by default, but this reads like scanning is
always happening...though it doesnt say what is being scanned. I think its
likely to be interpreted as being other files to do with the web stuff, so I
think it needs spelled out here if TLS reload is all this setting currently
governs, and also mention to the other config option given the 2 are documented
so far apart yet it is really the other setting that is more important (and the
other setting does reference this one).
##########
artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java:
##########
@@ -258,6 +277,10 @@ private ServerConnector
createServerConnector(HttpConfiguration httpConfiguratio
}
}
}
+ if (binding.getSslAutoReload() != null && binding.getSslAutoReload()
== true) {
Review Comment:
Perhaps replace the 2 checks with simply
Boolean.TRUE.equals(binding.getSslAutoReload()) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
