thezbyg commented on code in PR #4825:
URL: https://github.com/apache/activemq-artemis/pull/4825#discussion_r1494861064


##########
artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/VersionedStompFrameHandler.java:
##########
@@ -344,7 +348,8 @@ public StompFrame createMessageFrame(ICoreMessage 
serverMessage, StompSubscripti
       }
       frame.setByteBody(data);
 
-      StompUtils.copyStandardHeadersFromMessageToFrame((serverMessage), frame, 
deliveryCount);
+      frame.addHeader(Stomp.Headers.Message.MESSAGE_ID, 
String.valueOf(consumer.getID()) + StompSession.MESSAGE_ID_SEPARATOR + 
String.valueOf(serverMessage.getMessageID()));

Review Comment:
   Minimum long value is 20 characters (-9223372036854775808), so two long 
values and separator could require 41 characters total.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to