clebertsuconic commented on code in PR #4828:
URL: https://github.com/apache/activemq-artemis/pull/4828#discussion_r1496803798
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java:
##########
@@ -1901,18 +1901,10 @@ public void rollback(final Xid xid) throws XAException {
workDone = false;
} catch (XAException xae) {
throw xae;
- } catch (ActiveMQException e) {
- if (e.getType() == ActiveMQExceptionType.UNBLOCKED || e.getType() ==
ActiveMQExceptionType.CONNECTION_TIMEDOUT || e.getType() ==
ActiveMQExceptionType.SHUTDOWN_ERROR) {
- // Unblocked on failover
- throw new XAException(XAException.XA_RETRY);
- }
-
- // This should never occur
- XAException xaException = new XAException(XAException.XAER_RMFAIL);
- xaException.initCause(e);
- throw xaException;
} catch (Throwable t) {
- // This could occur if the TM interrupts the thread
+ if (logger.isTraceEnabled()) {
+ logger.trace("Rollback failed:: {}", convert(xid), t);
+ }
XAException xaException = new XAException(XAException.XAER_RMFAIL);
Review Comment:
would the TM retry the rollback in such event?
Did this request come from Wildly / @ehsavoie ?
My biggest concern in such changes is the integration with MDBs as I
remember having massive headaches with MDB / XA tests back then which I don't
want to go back :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
