clebertsuconic commented on code in PR #4827:
URL: https://github.com/apache/activemq-artemis/pull/4827#discussion_r1499550612
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerSource.java:
##########
@@ -281,6 +300,15 @@ public void sendMessage(Transaction tx, Message message,
RoutingContext context)
return;
}
+ if (snfQueue.getPagingStore().page(message, tx, pagedRouteContext,
this::copyMessageForPaging)) {
+ return;
+ }
+
+ if (message.isPaged()) {
+ // if the source was paged, we copy the message
+ message = copyMessageForPaging(message);
+ }
Review Comment:
I had to change the ID providers to return the ID from the broker property
if being set. so.. on that case the ID comes into the right place.
I did a lot of testing to make sure I got this right... a lot of work into
just that part of the acks from a different queue.. it wasn't easy to balance
it out. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
