clebertsuconic commented on code in PR #4840: URL: https://github.com/apache/activemq-artemis/pull/4840#discussion_r1514670185
########## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPLargeMessageWriter.java: ########## @@ -81,33 +84,55 @@ public boolean isWriting() { public void close() { if (!closed) { try { + try { + if (largeBodyReader != null) { + largeBodyReader.close(); + } + } catch (Exception e) { + // if we get an error only at this point, there's nothing else we could do other than log.warn + logger.warn("{}", e.getMessage(), e); + } if (message != null) { message.usageDown(); } } finally { - reset(true); + resetClosed(); } } } @Override - public AMQPLargeMessageWriter open() { - if (!closed) { - throw new IllegalStateException("Trying to open an AMQP Large Message writer that was not closed"); Review Comment: it was an honest mistake.. I didn't mean to.. will place it back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org