cshannon commented on PR #1172: URL: https://github.com/apache/activemq/pull/1172#issuecomment-2015372280
My initial comments of not to include it were because I thought you meant with Tech Preview as it's just for testing, etc and not really intended for users yet. If your intent is for users to try it out and then I think it would be ok to merge if we mark it as experimental/beta in the code itself besides just the documentation. As I already stated, I want to look at refactoring all of the `TaskRunner` usage, so it's possible the final result of this looks completely different and I just didn't want to merge something in that was a preview/testing feature that might break users. Maybe we could add something similar to @Beta annotation that Guava has to mark it as a preview feature and subject to breaking changes or removal as we don't know how it will go and I don't want to add it in if we can't get rid of it later. My guess is by the time we hit AMQ 7.0 it would certainly be considered stable but could be earlier if we did work on the threading. I suppose the other result of this change is it requires JDK 21 to build going forward for releases which I'm not sure how I feel about. The modules are optional but obviously we need to build them if we plan to release them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
