clebertsuconic commented on code in PR #4880:
URL: https://github.com/apache/activemq-artemis/pull/4880#discussion_r1561260496


##########
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/actors/ProcessorBase.java:
##########
@@ -117,13 +112,6 @@ public int shutdownNow(Consumer<? super T> onPendingItem, 
int timeout, TimeUnit
       requestedShutdown = true;
       yielded = false;
 
-      if (!inHandler()) {
-         // We don't have an option where we could do an immediate timeout
-         // I just need to make one roundtrip to make sure there's no pending 
tasks on the loop
-         // for that I ellected one second
-         flush(timeout, unit);

Review Comment:
   This was for tests and it was still causing issues anyway...
   
   
   so, time to go !!! more issues than benefits



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to